fix: NVSHAS-8682 remove misplaced resc from crds #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holyspectral
force-pushed
the
NVSHAS-8682-misplaced-resource-in-crds
branch
from
26df101 to
a403359
Compare
In the previous charts, a service neuvector-svc-crd-webhook is misplaced in crds charts. This commit fixes the issue. Note: This change would affect upgrade. Users are advised to upgrade crds first before upgrade core in order to prevent resource conflict.
To make sure crd webhook service is created correctly when combining with CRD charts, another option is added to enable/disable crd webhook service.
holyspectral
force-pushed
the
NVSHAS-8682-misplaced-resource-in-crds
branch
from
a403359 to
b999b37
Compare
|
Tested this branch, works as specified in the Jira. Customer need to update crd chart first if user used crd+core chart for deploying. |
selvamt94
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous charts, a service neuvector-svc-crd-webhook is misplaced in crds charts.
This commit fixes the issue.
Note: This change would affect upgrade. Users are advised to upgrade crds first before upgrade core to prevent resource conflict.