Merge pull request #143 from nevermined-io/issue/return_agreementID

Issue/return agreement

Author: josepablofm78

lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nevermined-io/catalog-core",
-  "version": "0.0.25",
+  "version": "0.0.26",
   "private": false,
   "scripts": {
     "watch": "./node_modules/.bin/nodemon",
@@ -36,7 +36,7 @@
     "react": "*"
   },
   "dependencies": {
-    "@nevermined-io/nevermined-sdk-js": "^0.22.5",
+    "@nevermined-io/nevermined-sdk-js": "^0.23.1",
     "@types/jsonwebtoken": "^8.5.8",
     "axios": "^0.27.2",
     "axios-retry": "^3.3.1",

lib/src/nevermined.tsx

@@ -895,31 +895,44 @@ export const NeverminedProvider = ({ children, config, verbose }: NeverminedProv
    * }
    * ```
    */
+  
+
   const subscription = {
+
+  
     /**
      * Order a NFT asset and transfer and delegate it to the subscription buyer
      * @param subscriptionDid Id of the NFT to subscribe
      * @param buyer The account who buy the subscription of the NFT asset
      * @param nftHolder The owner of the NFT asset
      * @param nftAmount The amount of NFT asset to buy
      * @param nftType NFT asset type which can be 721 or 1155
-     * @returns It is true if the subscription was successfully completed
+     * @returns string that contains the id of the agreement
+     * @throws Error when there is an exception ordering the nft or the transferForDelegate method returns false
      */
-    buySubscription: async (subscriptionDid: string, buyer: Account, nftHolder: string, nftAmount: number, nftType: NftTypes): Promise<boolean> => {
+    buySubscription: async (subscriptionDid: string, buyer: Account, nftHolder: string, nftAmount: number, nftType: NftTypes): Promise<string> => {
+      
+      let agreementId = ''
+      let transferResult = false
       try {
-        const agreementId = nftType === 721 ? await sdk.nfts.order721(subscriptionDid, buyer): await sdk.nfts.order(subscriptionDid, nftAmount, buyer);
-        return sdk.nfts.transferForDelegate(
+        agreementId = nftType === 721 ? await sdk.nfts.order721(subscriptionDid, buyer): await sdk.nfts.order(subscriptionDid, nftAmount, buyer);
+        transferResult = await sdk.nfts.transferForDelegate(
           agreementId,
           nftHolder,
           buyer.getId(),
           nftAmount,
           nftType
         )
-
       } catch (error) {
         verbose && Logger.error(error);
-        return false;
+        throw error
       }
+
+      if (!transferResult)
+        throw new Error("Error delegating the NFT of the subscription with agreement " + agreementId)
+        
+      return agreementId 
+      
     },
 
   };

lib/src/types/index.ts

@@ -223,7 +223,7 @@ export interface Transfer {
 }
 
 export interface SubscriptionActions {
-  buySubscription: (subscriptionDid: string, buyer: Account, nftHolder: string, nftAmount: number, nftType: NftTypes) => Promise<boolean>;
+  buySubscription: (subscriptionDid: string, buyer: Account, nftHolder: string, nftAmount: number, nftType: NftTypes) => Promise<string>;
 }
 
 export type { NftTypes } from '@nevermined-io/nevermined-sdk-js/dist/node/gateway/Gateway';