Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Issue/return agreement #143

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Issue/return agreement #143

merged 6 commits into from
Aug 19, 2022

Conversation

@josepablofm78
Copy link
Contributor

@josepablofm78 josepablofm78 commented Aug 18, 2022

Description

  • buySubscription method returns agreementID if everything works fine and throws Error if the order or transferForDelegate fail
  • sdk dependency updated to the latest version

Is this PR related with an open issue?

Issue #141 #142

@josepablofm78 josepablofm78 requested review from a team as code owners August 18, 2022 13:35
r-marques
r-marques reviewed Aug 18, 2022
View reviewed changes
r-marques
r-marques approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josepablofm78 josepablofm78 merged commit f6672d1 into main Aug 19, 2022
@josepablofm78 josepablofm78 deleted the issue/return_agreementID branch August 19, 2022 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@r-marques r-marques r-marques approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josepablofm78 @r-marques