This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Fix: progress event #268
Merged
Fix: progress event #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spielcrypto
reviewed
Mar 14, 2023
| const subscribablePromise = subscribableAction() | ||
| subscription = onEvent ? subscribablePromise.subscribe(onEvent) : undefined | ||
| return subscribablePromise | ||
| return await subscribablePromise |
Contributor
There was a problem hiding this comment.
is returning a promise anyway then await is not needed
Contributor
Author
There was a problem hiding this comment.
I need to execute the promise and return the result to the caller so that we can unsubscribe from the events inside this wrapper function when the promise is fulfilled or rejected.
spielcrypto
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The subscription event callback is not being called due to the missing execution of the promise which leads to immediate unsubscribing from the events.
Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif