Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Conversation

@spielcrypto
Copy link
Contributor

@spielcrypto spielcrypto commented Jun 9, 2023

Description

  • return only agreementId when transaction fail in order that the client decided how to show it
  • pass account by argument instead of Catalog handle internally

Is this PR related with an open issue?

Related to Issue:
https://github.com/nevermined-io/one/issues/578
https://github.com/nevermined-io/one/issues/586

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@spielcrypto spielcrypto requested review from a team as code owners June 9, 2023 10:58
@spielcrypto spielcrypto added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 916db15 Jun 13, 2023
@spielcrypto spielcrypto deleted the feat/agreementId-when-fail-transaction branch June 13, 2023 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants