Merge pull request #71 from nevermined-io/feat/sdk-peer-dependencie

feat: make the sdk a peer dependency

.github/workflows/testing-node.yml

@@ -26,21 +26,15 @@ jobs:
           frost-version: 'v3.2.2.004'
           node: 'false'
 
-      - name: Install sponge
-        run: sudo apt-get install -y moreutils
-
       - name: Install dependencies
         run: yarn
 
       - name: Build SDK-DTP package and node
         run: |
           yarn build
-          yarn pack
-          cp *dtp*.tgz ./node/dtp.tgz
 
           cd ./node
-          cat package.json | jq '.dependencies."@nevermined-io/sdk-dtp"="./dtp.tgz"' | sponge package.json
-          yarn
+          yarn add ../
           yarn run setup:dev
           yarn build
 

.github/workflows/testing.yml

@@ -9,8 +9,6 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
@@ -27,7 +25,7 @@ jobs:
       - name: Install dependencies
         run: |
           yarn
-      - name: Run linters
+      - name: Copy artifacts
         run: |
           nvm-tools copy-artifacts ./artifacts
           nvm-tools copy-circuits ./circuits

README.md

@@ -2,7 +2,7 @@
 
 # Nevermined SDK Data Transfer Proofs
 
-> Javascript Data Tranfer Proofs library
+> Javascript Data Transfer Proofs library
 > [nevermined.io](https://nevermined.io)
 
 [![CI Build](https://github.com/nevermined-io/sdk-dtp/actions/workflows/testing.yml/badge.svg)](https://github.com/nevermined-io/sdk-dtp/actions/workflows/testing.yml)
@@ -11,6 +11,10 @@
 
 ## Get started
 
+```bash
+$ yarn add @nevermined-io/sdk @nevermined-io/sdk-dtp
+```
+
 SDK Data Transfer Proofs (aka DTP) library allows the delivery of use cases involving encrypted assets in a Nevermined deployment.
 The library is packaged in NPM format:
 
@@ -28,7 +32,7 @@ For linting and auto-formatting you can use:
 
 ```bash
 # lint all ts with eslint
-yarn run lint
+yarn lint
 
 ```
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nevermined-io/sdk-dtp",
-  "version": "0.5.3",
+  "version": "0.6.0",
   "description": "Javascript SDK for connecting with Nevermined Data Platform (Data Transfer proofs module)",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -30,16 +30,19 @@
   },
   "homepage": "https://github.com/nevermined-io/sdk-dtp#readme",
   "dependencies": {
-    "@nevermined-io/sdk": "^1.5.4",
     "circomlibjs": "^0.1.1",
     "eciesjs": "^0.3.15",
     "ffjavascript": "^0.2.55",
     "node-rsa": "^1.1.1",
     "snarkjs": "^0.4.26",
     "web3-utils": "^1.7.4"
   },
+  "peerDependencies": {
+    "@nevermined-io/sdk": "^1.6.0-rc1"
+  },
   "devDependencies": {
     "@faker-js/faker": "^6.3.1",
+    "@nevermined-io/sdk": "^1.6.0-rc1",
     "@release-it/bumper": "^1.4.1",
     "@truffle/hdwallet-provider": "^1.0.42",
     "@types/chai": "^4.2.12",
@@ -49,8 +52,8 @@
     "@types/node": "^12.19.8",
     "@types/node-fetch": "^2.5.7",
     "@types/temp": "^0.8.34",
-    "@typescript-eslint/eslint-plugin": "^5.30.5",
-    "@typescript-eslint/parser": "^5.30.5",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
     "auto-changelog": "^1.16.4",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
@@ -77,9 +80,9 @@
     "stream-http": "^3.2.0",
     "tar": "^6.1.11",
     "terser-webpack-plugin": "^5.3.1",
-    "ts-node": "^8.10.2",
-    "typedoc": "^0.20.0",
-    "typescript": "^3.9.7",
+    "ts-node": "^10.9.1",
+    "typedoc": "^0.24.8",
+    "typescript": "^5.1.6",
     "url": "^0.11.0",
     "webpack": "^5.69.1",
     "webpack-cli": "^4.9.2",

src/Dtp.ts

@@ -351,7 +351,6 @@ export class Dtp extends Instantiable {
     // const { accessProofCondition } = this.nevermined.keeper.conditions
     const evOptions: EventOptions = {
       eventName: 'Fulfilled',
-      methodName: 'getFulfilleds',
       filterJsonRpc: { _agreementId: agreementId },
       filterSubgraph: { where: { _agreementId: agreementId } },
       result: {
@@ -387,7 +386,6 @@ export class Dtp extends Instantiable {
   ) {
     const evOptions: EventOptions = {
       eventName: 'Fulfilled',
-      methodName: 'getFulfilleds',
       filterJsonRpc: { _agreementId: agreementId },
       filterSubgraph: { where: { _agreementId: agreementId } },
       result: {