Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local font names to be missing #25

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Allow local font names to be missing #25

merged 2 commits into from
Jun 20, 2020

Conversation

dpeukert
Copy link
Contributor

From what I can tell, some fonts now don't provide local font names:

http GET 'https://fonts.googleapis.com/css?family=Lora&subset=latin'

# HTTP/1.1 200 OK
# 
# @font-face {
#   font-family: 'Lora';
#   font-style: normal;
#   font-weight: 400;
#   src: url(https://fonts.gstatic.com/s/lora/v15/0QI6MX1D_JOuGQbT0gvTJPa787weuxJBkqg.ttf) format('truetype');
# }

This PR changes the logic to no longer throw an error when a local font name is missing and also adds an gitignore file.

@dpeukert
Copy link
Contributor Author

Travis failure is unrelated (and fixed in #26).

@neverpanic neverpanic added the bug label Jun 20, 2020
@neverpanic neverpanic added this to the next milestone Jun 20, 2020
@neverpanic neverpanic merged commit 32e447a into neverpanic:master Jun 20, 2020
@neverpanic
Copy link
Owner

Thanks!

@dpeukert dpeukert deleted the fix/local-font-name branch June 20, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants