Support for relative dependencies for define(). #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this implementation is a little naive; it completely ignores the id given to define, and always assumes that URLs will be relative to the script's document. That will not work for vulcanized bundles. Separate PR for that.
nevir
force-pushed
the
0.8-amd-implicitly-relative
branch
from
1815237
to
7464430
Compare
|
|
|
I rather like |
| id = _inferModuleId(); | ||
| id = inferredId; | ||
| } | ||
| if (id.indexOf('\\') !== -1) { |
There was a problem hiding this comment.
I'd like to actually support it in the name of browser compatibility (AFAIK everyone but Firefox rewrites \ into / anyway). I'll stick a TODO on there
|
flippin' awesome: LGTM |
|
Killing off some of my really old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this implementation is a little naive; it completely ignores
the id given to define, and always assumes that URLs will be relative
to the script's document. That will not work for vulcanized bundles.
Separate PR for that.