Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define.withImports to reduce boilerplate a bit #3

Closed
wants to merge 2 commits into from

Conversation

nevir
Copy link
Owner

@nevir nevir commented Feb 26, 2015

No description provided.

@nevir nevir force-pushed the 0.8-amd-defineWithImports branch from f11e3e9 to 00c460e Compare February 26, 2015 01:33
@nevir nevir force-pushed the 0.8-amd-implicitly-relative branch from 1815237 to 7464430 Compare February 26, 2015 01:38
Note that this implementation is a little naive; it completely ignores
the id given to define, and always assumes that URLs will be relative
to the script's document. That will not work for vulcanized bundles.
Separate PR for that.
@nevir nevir force-pushed the 0.8-amd-defineWithImports branch from 00c460e to 70a4c0a Compare February 26, 2015 01:38
@nevir nevir force-pushed the 0.8-amd-defineWithImports branch from 70a4c0a to ff34844 Compare February 26, 2015 01:38
* &lt/script>
*
* **All** import link elements will be declared as dependencies for the
* defined module, and they will be declared in the same order.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens with html imports that don't export anything because they don't have a script? it'd be nice to get their <dom-module> or document...

@justinfagnani
Copy link

I think this could use some more discussion... make sure that it's forwards compatible with even more ways to make importing html awesomer.

@nevir
Copy link
Owner Author

nevir commented Aug 12, 2022

Killing off some of my really old PRs

@nevir nevir closed this Aug 12, 2022
@justinfagnani
Copy link

@nevir !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants