define.withImports to reduce boilerplate a bit #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevir
force-pushed
the
0.8-amd-defineWithImports
branch
from
f11e3e9
to
00c460e
Compare
nevir
force-pushed
the
0.8-amd-implicitly-relative
branch
from
1815237
to
7464430
Compare
Note that this implementation is a little naive; it completely ignores the id given to define, and always assumes that URLs will be relative to the script's document. That will not work for vulcanized bundles. Separate PR for that.
nevir
force-pushed
the
0.8-amd-defineWithImports
branch
from
00c460e
to
70a4c0a
Compare
nevir
force-pushed
the
0.8-amd-defineWithImports
branch
from
70a4c0a
to
ff34844
Compare
| * </script> | ||
| * | ||
| * **All** import link elements will be declared as dependencies for the | ||
| * defined module, and they will be declared in the same order. |
There was a problem hiding this comment.
what happens with html imports that don't export anything because they don't have a script? it'd be nice to get their <dom-module> or document...
|
I think this could use some more discussion... make sure that it's forwards compatible with even more ways to make importing html awesomer. |
|
Killing off some of my really old PRs |
|
@nevir !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.