Skip to content

Added internationalization and translated examples to german #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Oct 25, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2018

Additionally I added a .gitattributes file to force git on Windows to check out files with lf eol and not with crlf eol.

This should help to fix #116

@newbreedofgeek newbreedofgeek merged commit b28eb7d into newbreedofgeek:issue-116 Oct 25, 2018
@newbreedofgeek
Copy link
Owner

@tomtoxx amazing work! that looks incredible.

CCing @aweber1 @agent3bood @zeel @aapzu @elisechant @avivr FYI - @tomtoxx found some issues that made StepZilla not work with i18n (Internationalization and localization), I've fixed the issue and he then made an cool example use case where the example can be translated in runtime.

image

But we might have a small issue - the previously simple example code we had that didn't include i18n is a bit more complex now.

New users of StepZilla (there are close to 4000 per week now) who don't want i18n might find it harder to follow the example and integrate vanilla StepZilla into their project. This might lead to an influx of issues raised on github for help (which we don't want as we are already struggling to support the issues raised)

@tomtoxx can you think of some way to have both the existing vanilla example:
https://newbreedofgeek.github.io/react-stepzilla/

And the new example showing your amazing i18n update run side by side? for e.g.
https://newbreedofgeek.github.io/react-stepzilla/i18n (not sure if this is possible as we are using gitthub pages for hosting)

If we cant do the above we should at least break out the examples directory into sub examples.

e.g.
/examples --> the basic vanilla code
/examples/i18n --> the example with i18n

With the above we can support future use-cases of other example integrations as well without breaking the base basic vanilla example. (e.g. people have been asking for support for a redux sample)

What do you think? Lets discuss before we make the actual code update...

@ghost
Copy link
Author

ghost commented Oct 25, 2018

I am glad that you like this example so much 😄

Can understand your thoughts and agree with you. We should keep the example for beginners as simple as possible.

A general splitting of the examples into subdirectories should not be a problem in my opinion and is probably the smartest way.

You might also be able to create a sample home page where the user can choose the desired example, e.g. the Vanilla example, the i18n example, and for completeness, I can create a new FontAwesome example to show the user that you can not only pass a string to name:, but also React components.

@newbreedofgeek
Copy link
Owner

Done via PR #122

@ghost ghost deleted the issue-116 branch October 26, 2018 06:23
@newbreedofgeek
Copy link
Owner

This was delivered via #122 - Instruction are here - #122 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant