Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the pressure info inside the __repr__ method. #106

Closed
panDanieleN opened this issue Nov 7, 2023 · 2 comments
Closed

Add the pressure info inside the __repr__ method. #106

panDanieleN opened this issue Nov 7, 2023 · 2 comments
Assignees
@lelaus
Labels
bug Something isn't working
Milestone
Release of versio...

Comments

@panDanieleN
Copy link
Collaborator

Add the pressure value among the print returned by the __repr__
@panDanieleN panDanieleN added the invalid This doesn't seem right label Nov 7, 2023
@panDanieleN panDanieleN mentioned this issue Nov 7, 2023
Open
lelaus added a commit that referenced this issue Nov 7, 2023
@lelaus
[106_add_p_into_repr], issue - #106, Inserted the pressure value into…
d2e3ebb 
… the printed string and removed the keys handling of the __properties dict since useless
@lelaus
Copy link
Collaborator

lelaus commented Nov 7, 2023

In addition to insert the pressure value among the values printed into the stdout, the key management instruction has been removed. This instruction was needed when the keys of the __properties dict where made by two components, but now the keys are only made by the name of the properties, thus making the key management useless.

panDanieleN added a commit that referenced this issue Nov 8, 2023
@panDanieleN
Merge pull request #108 from newcleo-dev-team/106_add_p_into_repr
7dcbbd5 
[106_add_p_into_repr], issue - #106, Inserted the pressure value into…
@panDanieleN
Copy link
Collaborator Author

Merged into master.

No need to update tests.

Documentation update handled in #47

@panDanieleN panDanieleN added bug Something isn't working and removed invalid This doesn't seem right labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lelaus lelaus

Labels
bug Something isn't working
Projects
None yet
Milestone
Release of version 2 including thermo...
Development

No branches or pull requests
2 participants
@panDanieleN @lelaus