Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_custom_properties_path Improvement #110

Closed
lelaus opened this issue Nov 10, 2023 · 1 comment
Closed

set_custom_properties_path Improvement #110

lelaus opened this issue Nov 10, 2023 · 1 comment
Assignees
@lelaus
Labels
enhancement New feature or request
Milestone
Release of versio...

Comments

@lelaus
Copy link
Collaborator

lelaus commented Nov 10, 2023

Currently, when the input to the "set_custom_properties_path()" method is wrong, the wrong path is added to the module paths used by the liquid metal class. This results to an error that grows up any time a new liquid metal object is instantiated.
To solve this issue, the "set_custom_properties_path()" method should check the correctness of the input path, and add it only in case the check succeeds.
@lelaus lelaus added the enhancement New feature or request label Nov 10, 2023
@lelaus lelaus self-assigned this Nov 10, 2023
lelaus added a commit that referenced this issue Nov 22, 2023
@lelaus
[110_set_custom_property_path_improvement], issue - #110, Improved th…
cf3b0d9 
…e set_custom_property_path method by adding check on the module existence
lelaus added a commit that referenced this issue Nov 23, 2023
@lelaus
[110_set_custom_property_path_improvement], issue - #110, Updated lin…
38e67aa 
…k to ONCORE website in the README
@panDanieleN
Copy link
Collaborator

Merged into master.

No need to udpate documentation and tests.

@papantel papantel mentioned this issue Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lelaus lelaus

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release of version 2 including thermo...
Development

No branches or pull requests
2 participants
@panDanieleN @lelaus