-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking separator when calling set_custom_properties_path()
method
#153
Comments
…pathname in set_custom_properties_path + used pathlib.os.sep to split the provided path
The error described in #144 concerning
In other words, it returns a warning saying that the file does not exist and the module is not added. I think this behaviour is ok: the file does not exists if the separator is wrong. |
Merged into master. No need to update doc and tests. |
This issue is relating to the last task of issue #144.
The
set_custom_properties_path()
method loads properties from the module whose path is passed as argument.Currently, no check is made about the separator used in the passed path, so no catching any issue in case the used separator is not in accordance with the OS.
The check is needed to make the
set_custom_properties_path()
method more robust.This issue is also related to issue #121, which is about the package to use for handling the separator-related aspects.
The text was updated successfully, but these errors were encountered: