Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking the way the correlations provided with different validity ranges have been selected #157

Closed
lelaus opened this issue Mar 9, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@lelaus
Copy link
Collaborator

lelaus commented Mar 9, 2024

This issue is related to the first task of the "Ranges of Validity" section in issue #147.

The reference handbook provides multiple validity ranges for some correlations. This aspect has been discussed together with the authors of the handbook. Together with them, it has been decided to adopt in lbh15 the lowest range. After having analysed the old issue(s) dealing with this aspect, the corresponding information should be detailed in the "Ranges of Validity" section of the doc.

@lelaus lelaus added the documentation Improvements or additions to documentation label Mar 9, 2024
panDanieleN added a commit that referenced this issue Mar 25, 2024
…n of doc + minor fix in docstring of lead_oxygen_limit
@panDanieleN
Copy link
Collaborator

Communication with authors of the handbook are not related to this section of the doc. As explained in #44 they are related to the choice of some default correlations to adopt in lbh15. Going to share with @lelaus the summary of that communications.

Therefore, I just rephrased the section and followed the suggestions given in #147.

panDanieleN added a commit that referenced this issue Mar 25, 2024
@lelaus
Copy link
Collaborator Author

lelaus commented Mar 25, 2024

Documentation modified as described by commits.

No need to update tests.

@lelaus lelaus closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants