Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check .pli file loaded #36

Closed
lelaus opened this issue Nov 5, 2024 · 2 comments
Closed

Check .pli file loaded #36

lelaus opened this issue Nov 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lelaus
Copy link
Collaborator

lelaus commented Nov 5, 2024

The check on the .pli file loaded is performed only partially: instead of checking both its extension and its existence, only the latter is actually checked. Each of such checks is implemented into a dedicated method: the two resulting methods are associated to the same event, that is triggered when the Entry widget loses its focus. This results in triggering only the lastly called method.

In addition, if the .pli file path is entered manually, the initial and output folders are not extracted. This results in an erroneous folder where any next .pli selection window is opened. Think about merging the ways the entered .pli file is managed.

@lelaus lelaus added the bug Something isn't working label Nov 5, 2024
@dmanzione
Copy link
Collaborator

So far the EntryVariable class used a fixed validation procedure, implemented directly within the class itself.
In 4f12e94 it has been modified by giving the user the possibility to define the validation function to use at the instantiation of the EntryVariable class. The validation is now triggered each time a text is inserted in the entry widget.
The validation consists of the two required steps, first by checking the extension, second by checking the file existence.
If the validation passes, a new event has been declared so to trigger the method for retrieving the information from the input .pli file.
Within this last method, the initial and output folders are updated accordingly, no matter the .pli file path is entered manually or not.

@dmanzione
Copy link
Collaborator

The bugs related to the .pli entry validation have been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants