Type Hints #25
Merged
Type Hints #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods in gui_widgets module
…tic tests to include the installation of typing-extensions module
…le until the class OnOffClickableLabel
…hint by setting Callable type hint
…and not working
…uilder.py module
dmanzione
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
All the required modifications about adding type hints for arguments of methods/functions and returned variables have been applied successfully. The code has improved its readability, maintainability and usage.
The branch can now be merged into the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints to all the methods and the class and instance variables for improving the readability and maintainability of the code.