Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer component #28

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Drawer component #28

merged 4 commits into from
Feb 12, 2025

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Feb 6, 2025

Proposed changes

Add a side drawer component:

  • Uses https://headlessui.com/react/dialog under the hood to handle animation, scrolling and accessibility.
  • Two variants: classic and offset.
  • Left and right direction support.
  • Content width is handled by the consumer.
  • Scrollable.
  • Optional header Drawer.Header component that adds title and X button.
  • Dismissible by: Esc, overlay click or X click.

Demo

1-3-0-drawer.mp4

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani merged commit 2554bfa into main Feb 12, 2025
@wpalani wpalani deleted the add/drawer branch February 12, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants