-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Coming Soon admin site status badge with WooCommerce's #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our admin bar is growing more complex and being couple with other plugins, it makes more sense to split it out of the parent class.
Woo has it's own coming soon preview notice now, we'll default to that when Woo is active
Module tests are passing: https://github.com/newfold-labs/wp-module-coming-soon/actions/runs/11753678396/job/32746822585?pr=41#step:31:117 The failing tests are in the Onboarding, pretty sure they're not related to this PR. |
wpscholar
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Recently WooCommerce added their own coming soon functionality and part of it is an admin bar site status badge. So now when Woo is active the site will have 2 site status badges in the admin bar that can be out of sync and confusing.
This PR aims to solve that by addressing: P8-50
WooCommerceOptionsSync
class to unify the options values in the DB.coming-soon-woo.cy.js
that checks theirs for simple things like structure, location and content.Type of Change
Video
The video showcases the new admin badge with Woo inactive and then active, as well as the site preview warning.
https://github.com/user-attachments/assets/85f2808b-af93-454f-be69-10f48293f6a1
Checklist
Further comments
https://jira.newfold.com/browse/PRESS8-50