Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecommerce version bump to 1.3.44 #725

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

  • Move capabilities check behind init and is_admin

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Sep 19, 2024

HostGator Plugin    Run #4965

Run Properties:  status check failed Failed #4965  •  git commit b88e152ad1: Merge branch 'update/onboarding' into update/ecommerce-version-1.3.44
Project HostGator Plugin
Branch Review update/ecommerce-version-1.3.44
Run status status check failed Failed #4965
Run duration 26m 31s
Commit git commit b88e152ad1: Merge branch 'update/onboarding' into update/ecommerce-version-1.3.44
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 333
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/product-page.cy.js • 3 failed tests

View Output Video

Test Artifacts
Product Page > Show loading state while fetching Test Replay Screenshots Video
Product Page > Product page content is visible Test Replay Screenshots Video
Product Page > Show error state if fetching fails Test Replay Screenshots Video

Copy link

cypress bot commented Sep 19, 2024

HostGator Plugin    Run #4916

Run Properties:  status check passed Passed #4916  •  git commit 8ac757069f ℹ️: Merge 7369b4d45950b52837a2179509ef671f1f3eb790 into 79d6d77b760853d3d7f0125f073e...
Project HostGator Plugin
Branch Review update/ecommerce-version-1.3.44
Run status status check passed Passed #4916
Run duration 25m 32s
Commit git commit 8ac757069f ℹ️: Merge 7369b4d45950b52837a2179509ef671f1f3eb790 into 79d6d77b760853d3d7f0125f073e...
Committer Ramya
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the October 2 milestone Sep 25, 2024
* develop:
  Composer(deps): Bump newfold-labs/wp-module-migration
  update ecommerce module to 1.3.44
  NPM(deps): Bump @wordpress/icons from 10.7.0 to 10.8.0
  WordPress i18n triggered by commit 0daae5e
  Update version number to 2.11.6

# Conflicts:
#	composer.lock
* update/onboarding:
  Composer(deps): Bump newfold-labs/wp-module-migration
  update ecommerce module to 1.3.44
  Bump Onboarding
  NPM(deps): Bump @wordpress/icons from 10.7.0 to 10.8.0
  WordPress i18n triggered by commit 0daae5e
  Update version number to 2.11.6

# Conflicts:
#	composer.lock
@circlecube circlecube merged commit 93612c0 into develop Sep 26, 2024
2 of 4 checks passed
@circlecube circlecube deleted the update/ecommerce-version-1.3.44 branch September 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants