Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more LATAM regions #760

Merged
merged 15 commits into from
Oct 25, 2024
Merged

Add more LATAM regions #760

merged 15 commits into from
Oct 25, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

https://jira.newfold.com/browse/PRESS10-6

  • add links mapped per region in the data/region file
  • add new country codes to js helper to load the proper region-based content
  • add BO to list of locales to load existing MX translation files
  • also alpha sort all countries for consistency and readability

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

circlecube and others added 10 commits October 17, 2024 15:40
@circlecube
update data module from 2.6.3 to 2.6.4
d2c3b3e
@circlecube
update plugin version from 2.11.7 to 2.11.8
6f938db
@actions-user
WordPress i18n triggered by commit 97f0062
f59f9cb
@circlecube
i18n updates
7abd4b7
@circlecube
Merge branch 'release/2.11.8' of https://github.com/newfold-labs/wp-p…
459166e 
…lugin-hostgator into release/2.11.8

* 'release/2.11.8' of https://github.com/newfold-labs/wp-plugin-hostgator:
  WordPress i18n triggered by commit 97f0062
@circlecube
Merge pull request #752 from newfold-labs/release/2.11.8
b8d745a 
Release/2.11.8
@circlecube
add BO to list of locales to load existing MX translation files
c1da716 
also alphabetize countries by country code
@circlecube
add new country codes to js helper to load the proper region-based co…
fb94f9f 
…ntent

alpha sort countries
@circlecube
add links mapped per region in the data/region file
fd0cb46 
alpha sort countries in mapped values for readability
@circlecube
remove stray whitespace for lint happiness
d12fb2a
@circlecube circlecube requested a review from abhijitb October 24, 2024 18:24
@circlecube circlecube self-assigned this Oct 24, 2024
@trag-bot Trag bot
Copy link

trag-bot bot commented Oct 24, 2024

@trag-bot didn't find any issues in the code! ✅✨

@trag-bot Trag bot
Copy link

trag-bot bot commented Oct 24, 2024

@trag-bot didn't find any issues in the code! ✅✨

@circlecube circlecube changed the base branch from main to develop October 24, 2024 18:28
@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024 •
edited
Loading

HostGator Plugin    Run #5059

Run Properties:  status check passed Passed #5059  •  git commit 4bc3aa0ce6 ℹ️: Merge 1c03700829b004627219ee0135ebb2b928c5869a into a7ea942a4da5105ed91249e9a22d...
Project HostGator Plugin
Branch Review update/latam-regions
Run status status check passed Passed #5059
Run duration 23m 49s
Commit git commit 4bc3aa0ce6 ℹ️: Merge 1c03700829b004627219ee0135ebb2b928c5869a into a7ea942a4da5105ed91249e9a22d...
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024 •
edited
Loading

HostGator Plugin    Run #5068

Run Properties:  status check passed Passed #5068  •  git commit 873e4a2bd7: correct br chat link that was inadvertently changed
Project HostGator Plugin
Branch Review update/latam-regions
Run status status check passed Passed #5068
Run duration 25m 24s
Commit git commit 873e4a2bd7: correct br chat link that was inadvertently changed
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the October 30, 2024 Release milestone Oct 24, 2024
@circlecube
update region links as directed
7ddf55f
@circlecube
Merge branch 'update/latam-regions' of https://github.com/newfold-lab…
3012c16 
…s/wp-plugin-hostgator into update/latam-regions

* 'update/latam-regions' of https://github.com/newfold-labs/wp-plugin-hostgator:
  WordPress i18n triggered by commit 3daebd9
@circlecube
Merge branch 'develop' into update/latam-regions
9a791da 
also ran `composer bump`

* develop:
  NPM(deps): Bump @wordpress/element from 6.8.0 to 6.10.0
  NPM(deps): Bump @wordpress/compose from 7.7.0 to 7.10.0
  Composer Dev(deps-dev): Bump wp-cli/i18n-command from 2.6.2 to 2.6.3
  Composer(deps): Bump newfold-labs/wp-module-onboarding
  NPM(deps): Bump @wordpress/dom-ready from 4.8.0 to 4.10.0
  NPM Dev(deps-dev): Bump tailwindcss from 3.4.12 to 3.4.14
  NPM Dev(deps-dev): Bump cypress from 13.14.2 to 13.15.0

# Conflicts:
#	composer.lock
@trag-bot Trag bot
Copy link

trag-bot bot commented Oct 24, 2024

@trag-bot didn't find any issues in the code! ✅✨

trag-bot[bot]
trag-bot bot reviewed Oct 24, 2024
View reviewed changes
src/app/data/region.js
},
help_phone_number: {
help_phone_number: { // a string false value will remove this section
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of a string 'false' to conditionally remove sections is error-prone and can lead to confusion. Consider using a boolean value instead for clarity and to prevent potential bugs.

trag-bot[bot]
trag-bot bot reviewed Oct 24, 2024
View reviewed changes
src/app/data/region.js
},
help_twitter: {
help_twitter: { // a string false value will remove this section
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a string 'false' to conditionally remove sections is not a best practice. It can lead to misunderstandings and errors. A boolean value should be used for better code clarity and reliability.

@circlecube
Copy link
Member Author

With the other changes merged into this branch, I also ran composer bump to list exact version of modules that were included in the lock file. The modules that look like they are updated in this pr were updated previously and the composer file wasn't updated at that point. This change just brings them in line with each other.

@circlecube circlecube requested review from wpscholar, wpalani and a team October 25, 2024 15:14
@circlecube circlecube merged commit 8de9e77 into develop Oct 25, 2024
4 checks passed
@circlecube circlecube deleted the update/latam-regions branch October 25, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trag-bot trag-bot[bot] trag-bot[bot] left review comments

@wpscholar wpscholar wpscholar approved these changes

@abhijitb abhijitb Awaiting requested review from abhijitb

@wpalani wpalani Awaiting requested review from wpalani

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
October 28, 2024 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@circlecube @wpscholar @actions-user