-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NJWE-2499 - Training Details frontend update #3093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opp Title and Provider name
- Mobile: 1.5rem font size
- Provider name: 1.2 line height (same as content box descriptions)
In-demand box (failing contrast in lighthouse)
Total hours tooltip
- Move icon to top line
Occupation and Instructional Blocks
- Remove period at end of list item
- Add code # to Occupation items (like with Instructional items)
- Mobile: text is centered and spanning the whole width
- When drawers are open, tabbing through does not focus on drawer but continues to the links in those content boxes
Funding Block
Report Button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolves NJWE-2499
What I did: