Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJWE-2499 - Training Details frontend update #3093

Merged
merged 12 commits into from
Jan 3, 2025
Merged

NJWE-2499 - Training Details frontend update #3093

merged 12 commits into from
Jan 3, 2025

Conversation

scwambach
Copy link
Collaborator

@scwambach scwambach commented Dec 6, 2024

resolves NJWE-2499

What I did:

  • updated the frontend for the training details pages
  • Dev review
  • Design review

@scwambach scwambach requested a review from ChelseaKR December 6, 2024 19:46
@scwambach scwambach requested a review from mflymfly December 6, 2024 20:33
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error when trying to do a search on TE.

image

@mflymfly mflymfly self-requested a review December 10, 2024 19:01
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opp Title and Provider name

  • Mobile: 1.5rem font size
  • Provider name: 1.2 line height (same as content box descriptions)

In-demand box (failing contrast in lighthouse)

  • Underline One-stop link
  • make link color: primary-dark
    image

Total hours tooltip

  • Move icon to top line

image

Occupation and Instructional Blocks

  • Remove period at end of list item
  • Add code # to Occupation items (like with Instructional items)
    image
  • Mobile: text is centered and spanning the whole width
  • When drawers are open, tabbing through does not focus on drawer but continues to the links in those content boxes

image

Funding Block

  • Buttons and button text left align
    image

Report Button

  • Make test in button black
  • Default fill state: accent-warm-lighter (#F2E4D4)
  • Hover state changes fill color: accent-warm-light (#FFBC78)
    image

@scwambach scwambach requested a review from mflymfly December 11, 2024 17:21
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two quick things:

Report Button

  • Text align left
Screenshot 2024-12-11 at 3 15 19 PM

CIP Code Link

  • External Link Icon is small on mobile
  • Should be moved next to text and wrap with it
    image

@scwambach scwambach requested a review from mflymfly December 11, 2024 21:12
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChelseaKR ChelseaKR merged commit a66c408 into nextjs Jan 3, 2025
1 of 2 checks passed
@ChelseaKR ChelseaKR deleted the ce-styles branch January 3, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants