Cms unifying filename id 188347468 #9352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphechter
reviewed
Jan 3, 2025
| @@ -4,25 +4,25 @@ summaryDescriptionMd: |- | |||
|
|
|||
| A few sentences with the most important information is enough. | |||
| urlSlug: task-test | |||
| filename: task-test | |||
There was a problem hiding this comment.
@adidner we need to delete this
jphechter
reviewed
Jan 3, 2025
web/public/mgmt/config.yml
Outdated
| @@ -1332,12 +1320,13 @@ collections: | |||
| - { label: "Disabled Veteran Owned", value: "disabled-veteran" } | |||
| - { label: "LGBTQ Owned", value: "lgbtq-owned" } | |||
| - { label: "is SBE (show if fewer than 120 employees)", name: "isSbe", widget: boolean, default: false } | |||
| # TODO: Do we want to keep "archived" collections? - idk but its a sand, because I don't want to talk to content more during this ticket, will slow things down unnecessarily. So I'mma fix it for now real quick | |||
There was a problem hiding this comment.
@adidner can you add information about this to the PR description, please?
jphechter
reviewed
Jan 3, 2025
web/public/mgmt/config.yml
Outdated
| @@ -2482,12 +2453,12 @@ collections: | |||
| required: false, | |||
| } | |||
|
|
|||
| - name: "tasks" | |||
| - name: "tasks" # TODO: also some webflow stuff and sync script stuff to do | |||
There was a problem hiding this comment.
Suggested change
| - name: "tasks" # TODO: also some webflow stuff and sync script stuff to do | |
| - name: "tasks" |
jphechter
reviewed
Jan 3, 2025
web/public/mgmt/config.yml
Outdated
| @@ -2693,20 +2632,20 @@ collections: | |||
| - { label: "Call To Action Text", name: "callToActionText", widget: "string", required: false } | |||
| - { label: "Call To Action Link", name: "callToActionLink", widget: "string", required: false } | |||
|
|
|||
| - name: "webflow-licenses" | |||
| - name: "webflow-licenses" # TODO: fuck with sync scripts, also there is no ID here soooo, are we replacing filename with ID? | |||
There was a problem hiding this comment.
Suggested change
| - name: "webflow-licenses" # TODO: fuck with sync scripts, also there is no ID here soooo, are we replacing filename with ID? | |
| - name: "webflow-licenses" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we wanted to unify filename and id into just id across the CMS. This is because we've had some bugs over time that are a result of this and we want a single source of truth moving forward.
Ticket
This pull request resolves #188347468 and #188671780.
Approach
we used vscode global search and regex's to find and replace filename with id where relevant or delete filename where both existed. Then we used a script to double check that all id's matched actual incode filenames.
Also things like label and displayname that referenced filename now reference id
we also changed all our dropdowns in the config.yml file to reference ID instead.
Steps to Test
look through CMS and make sure things look alright.
Poke around the app to make sure the various types of things aren't broken (look for a license, look for a generic task, look for some roadmap variations etc)
Notes
Do we want to keep "archived" collections? - idk but its a sand, because I don't want to talk to content more during this ticket, will slow things down unnecessarily. So I'mma fix it for now real quick
in loadAllFilings and loadAllFilingsbyUrlSlug we have some wonky pattern stuff going on where we need both loadAllFilingsByUrlSlug and loadAllFilingsByFilename but really we probably shouldn't and it can be made smoother
Code author checklist
userData(includingprofileData,formationDataetc), then I added a new migration filecmsCollections.ts(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).envvalues in both.env-templateand in Bitwarden