Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby workflow enhancements #75

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Ruby workflow enhancements #75

merged 1 commit into from
Jun 3, 2024

Conversation

fallwith
Copy link
Contributor

@fallwith fallwith commented Jun 3, 2024

  • checkout@v3 uses a deprecated Node.js v16 runtime and should be updated to v4
  • Ruby 3.3 (not 3.2) is the latest stable Ruby, so update setup-ruby to use v3.3
  • We have multiple public Ruby repos that have Gemfile.lock intentionally ignored by Git, but FOSSA wants that file so autogenerate it running bundle lock where appropriate
    • Do not run bundle lock if a lock file already exists
    • Handle multiple Gemfile locations (the NR Ruby agent has 2)
    • Ignore the test/ and spec/ directories

@fallwith
Ruby workflow enhancements
df39fd3 
- checkout@v3 uses a deprecated Node.js v16 runtime and should be
  updated to v4
- Ruby 3.3 (not 3.2) is the latest stable Ruby, so update setup-ruby to
  use v3.3
- We have multiple public Ruby repos that have `Gemfile.lock`
  intentionally ignored by Git, but FOSSA wants that file so
  autogenerate it running `bundle lock` where appropriate
  - Do not run `bundle lock` if a lock file already exists
  - Handle multiple `Gemfile` locations (the NR Ruby agent has 2)
  - Ignore the `test/` and `spec/` directories
elaguerta-nr
elaguerta-nr approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@elaguerta-nr elaguerta-nr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking for the lockfile before running bundle install, and for testing it on ruby agent. This should resolve errors for a few other repos. Thanks for your contribution!

@elaguerta-nr elaguerta-nr merged commit b12b334 into newrelic:main Jun 3, 2024
8 checks passed
cmboling
cmboling reviewed Jun 3, 2024
View reviewed changes
Copy link

@cmboling cmboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmboling cmboling cmboling left review comments

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@elaguerta-nr elaguerta-nr elaguerta-nr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fallwith @cmboling @kaylareopelle @elaguerta-nr