Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging level for secrets #190

Merged
merged 3 commits into from
Dec 5, 2018

Conversation

MidnightsFX
Copy link

Deployments will no longer show container configurations unless you set a lower logging level. This should hide secrets which are passed to containers at startup.

You can continue to view secrets for production deploys by turning up your log level.

…troubleshooting you wont see container configurations during a deploy.
@aughr
Copy link
Contributor

aughr commented Dec 4, 2018

Seems reasonable to me, would like @intjonathan to chime in as well.

@intjonathan
Copy link
Contributor

intjonathan commented Dec 4, 2018

I'd like to still print a subset at INFO, at least container ID, so at that level you can see:

Creating new container for quay.io/ubuntu/ubuntu
Starting new container 20abc302
Started 20abc302 successfully

Then at DEBUG you'd see the inspect line below that.

@intjonathan intjonathan merged commit 38ef3bf into newrelic:master Dec 5, 2018
@MidnightsFX MidnightsFX deleted the no_prod_secrets branch December 5, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants