Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: race condition when tracing async_nolink processes #118

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Fix: race condition when tracing async_nolink processes #118

merged 2 commits into from
Jun 10, 2019

Conversation

zoevkay
Copy link
Contributor

@zoevkay zoevkay commented Jun 7, 2019

Description

Discovered a race condition where, when an async_nolink process is started within a transaction, if it finishes after the transaction has completed, the transaction it is linked to no longer exists so the process's results will not be reported.

This PR removes the linking of an async_nolink process to a transaction so that it will consistently be reported to the agent. Note: when using erlang 20, the logging is async and the race condition still exists.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2019

CLA assistant check
All committers have signed the CLA.

@binaryseed
Copy link
Collaborator

Thanks @zoevkay !!

FYI, our thinking behind this is that using async_nolink is signaling that the work done is not part of the current "Transaction", so we aren't going to try tracking it...

@binaryseed binaryseed merged commit e7f9ef0 into newrelic:master Jun 10, 2019
@zoevkay zoevkay deleted the async-nolink-bug branch June 10, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants