Skip to content

Conversation

@zoeoverthere
Copy link

@zoeoverthere zoeoverthere commented Jun 7, 2019

Description

Discovered a race condition where, when an async_nolink process is started within a transaction, if it finishes after the transaction has completed, the transaction it is linked to no longer exists so the process's results will not be reported.

This PR removes the linking of an async_nolink process to a transaction so that it will consistently be reported to the agent. Note: when using erlang 20, the logging is async and the race condition still exists.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2019

CLA assistant check
All committers have signed the CLA.

@binaryseed
Copy link
Collaborator

Thanks @zoevkay !!

FYI, our thinking behind this is that using async_nolink is signaling that the work done is not part of the current "Transaction", so we aren't going to try tracking it...

@binaryseed binaryseed merged commit e7f9ef0 into newrelic:master Jun 10, 2019
@zoeoverthere zoeoverthere deleted the async-nolink-bug branch June 10, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants