Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collector error handling #156

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

binaryseed
Copy link
Collaborator

This PR refactors our error handling that deals with possible responses from the New Relic "collector"

  • Consistent usage of :ok and :error tuples
  • Clarified module purpose
  • Explicit testing of more rare edge cases

sidekick/ @mattbaker

@binaryseed binaryseed merged commit ecca91b into newrelic:master Nov 14, 2019
@binaryseed binaryseed deleted the more-connect-errors branch November 14, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant