Add docker id to the utilization vendors #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, this is super helpful! I hope to get this pulled in next week (though things in the world are a bit crazy right now) |
If the agent detects that the app is running inside a container the
container ID is added to the utilization map as:
%{docker: %{id: "<CONTAINER_ID>"}}
The conatainer ID is taken from the file "/proc/self/cgroup". It's
taken from the first cgroup in the file that meets the following
requirements:
- The definition must contain 3 parts separated by a colon.
- It must specify the cpu subsystem.
- The contianer ID is the last item in the cgroup path and it should
be a 64-digit hex string.
alejandrodnm
force-pushed
the
adn/fetch_container_id
branch
from
a407447 to
f93ea6e
Compare
|
Thanks, I'm going to merge into a feature branch for a few tweaks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the agent detects that the app is running inside a container the container ID is added to the utilization map as:
%{docker: %{id: "<CONTAINER_ID>"}}
The conatainer ID is taken from the file "/proc/self/cgroup". It's taken from the first cgroup in the file that meets the following requirements:
Fixes #204