Fix tracer bug with struct literal and enforced_keys #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbaker
reviewed
May 29, 2020
| @@ -223,6 +223,12 @@ defmodule NewRelic.Tracer.Macro do | |||
| Macro.postwalk(args, &rewrite_call_term/1) | |||
| end | |||
|
|
|||
| # Unwrap Structs into Maps when reporting | |||
| # They can't always be re-referenced directly since they can have enforced_keys | |||
| def rewrite_call_term({:%, _, [{:__aliases__, _, _} = struct, {:%{}, line, members}]}) do | |||
There was a problem hiding this comment.
Had to play around in iex, but to make sure I understand: this function works because the first value of that tuple would be :%{} if this was a map, vs :% when it's a struct, right?
There was a problem hiding this comment.
Yeah, it's basically unwrapping a struct literal into plain map.
It's data that's only used for reporting so it's not changing any aspect of the function definition itself.
mattbaker
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a tracer compilation issue when an argument is a matched struct with
enforced_keysfixes #229