Add basic support for "Other" transactions #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about distributed trace? Is |
binaryseed
added a commit
to binaryseed/elixir_agent
that referenced
this pull request
Jan 26, 2019
Add basic support for "Other" transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables tracking a given process as an "Other" transaction (ie: not a Web transaction). Had to do a minimal amount of refactoring to allow this, and included a little re-shuffling of functions.
You may track a process that isn't currently part of another transaction. (note: A process spawned in a Web request is part of that web transaction).
Be careful tracking long running processes, as memory usage will grow while collecting attributes & function traces
Normal Web transactions should still
use NewRelic.Transactioncloses #83