Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecs-fargate-task-definition to solve bug that prevents passing ARN references #27

Conversation

jsubirat
Copy link
Contributor

@jsubirat jsubirat commented Sep 5, 2023

This PR updates the ecs-fargate-task-definition version in order to include this fix: cn-terraform/terraform-aws-ecs-fargate-task-definition#30. The fix was introduced in 1.0.30, but I chose to update to the latest patch version. Specifically, this will allow us to pass task custom policies like this:

resource "aws_secretsmanager_secret" "foo" {
  name = "bar"
}

...

task_custom_policies = [
    jsonencode(
      {
        "Version" : "2012-10-17",
        "Statement" : [
          {
            "Effect" : "Allow",
            "Action" : [
              "secretsmanager:GetSecretValue"
            ],
            "Resource" : [
              aws_secretsmanager_secret.foo.arn
            ]
          }
        ]
      }
    )

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogercoll rogercoll merged commit 81b9fb8 into newrelic:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants