-
Notifications
You must be signed in to change notification settings - Fork 301
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
prevent all transaction methods from nil transaction errors (#1001)
* prevent all transaction methods from executing against nil transaction object * fix: incorrect nil logic for segments
- Loading branch information
Showing
3 changed files
with
114 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package newrelic | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net/http" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestTransaction_MethodsWithNilTransaction(t *testing.T) { | ||
| var nilTxn *Transaction | ||
|
|
||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| t.Errorf("panics should not occur on methods of Transaction: %v", r) | ||
| } | ||
| }() | ||
|
|
||
| // Ensure no panic occurs when calling methods on a nil transaction | ||
| nilTxn.End() | ||
| nilTxn.SetOption() | ||
| nilTxn.Ignore() | ||
| nilTxn.SetName("test") | ||
| name := nilTxn.Name() | ||
| if name != "" { | ||
| t.Errorf("expected empty string, got %s", name) | ||
| } | ||
| nilTxn.NoticeError(fmt.Errorf("test error")) | ||
| nilTxn.NoticeExpectedError(fmt.Errorf("test expected error")) | ||
| nilTxn.AddAttribute("key", "value") | ||
| nilTxn.SetUserID("user123") | ||
| nilTxn.RecordLog(LogData{}) | ||
| nilTxn.SetWebRequestHTTP(nil) | ||
| nilTxn.SetWebRequest(WebRequest{}) | ||
| nilTxn.SetWebResponse(nil) | ||
| nilTxn.StartSegmentNow() | ||
| nilTxn.StartSegment("test segment") | ||
| nilTxn.InsertDistributedTraceHeaders(http.Header{}) | ||
| nilTxn.AcceptDistributedTraceHeaders(TransportHTTP, http.Header{}) | ||
| err := nilTxn.AcceptDistributedTraceHeadersFromJSON(TransportHTTP, "{}") | ||
| if err != nil { | ||
| t.Errorf("expected no error, got %v", err) | ||
| } | ||
| app := nilTxn.Application() | ||
| if app != nil { | ||
| t.Errorf("expected nil, got %v", app) | ||
| } | ||
| bth := nilTxn.BrowserTimingHeader() | ||
| if bth != nil { | ||
| t.Errorf("expected nil, got %v", bth) | ||
| } | ||
| newTxn := nilTxn.NewGoroutine() | ||
| if newTxn != nil { | ||
| t.Errorf("expected nil, got %v", newTxn) | ||
| } | ||
| traceMetadata := nilTxn.GetTraceMetadata() | ||
| if traceMetadata != (TraceMetadata{}) { | ||
| t.Errorf("expected empty TraceMetadata, got %v", traceMetadata) | ||
| } | ||
| linkingMetadata := nilTxn.GetLinkingMetadata() | ||
| if linkingMetadata != (LinkingMetadata{}) { | ||
| t.Errorf("expected empty LinkingMetadata, got %v", linkingMetadata) | ||
| } | ||
| isSampled := nilTxn.IsSampled() | ||
| if isSampled { | ||
| t.Errorf("expected false, got %v", isSampled) | ||
| } | ||
| csecAttributes := nilTxn.GetCsecAttributes() | ||
| if csecAttributes != nil { | ||
| t.Errorf("expected nil, got %v", csecAttributes) | ||
| } | ||
| nilTxn.SetCsecAttributes("key", "value") | ||
| } |