Release 3.15.2 #418
Merged
Release 3.15.2 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… earlier redaction code
Logger license
Release 3.15.2
Ak-x
requested changes
Dec 6, 2021
v3/internal/logger/logger.go
Outdated
| // scrub license keys from any portion of the log message | ||
| re := regexp.MustCompile(`license_key=[a-fA-F0-9.]+`) | ||
| sanitized := re.ReplaceAllLiteralString(string(js), "license_key=[redacted]") | ||
| f.l.Print(sanitized) | ||
| } else { | ||
| f.l.Printf("unable to marshal log entry: %v", err) |
There was a problem hiding this comment.
Would it be helpful to have a check outside as well on the off-chance that our key is printed
update to logger redaction
Ak-x
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.15.2
Added
license_key=hex-string changed tolicense_key=[redacted]before they are output, regardless of severity level, where hex-string means a sequence of upper- or lower-case hexadecimal digits and dots ('.'). This incorporates PR #415.Support Statement
New Relic recommends that you upgrade the agent regularly to ensure that you’re getting the latest features and performance benefits. Additionally, older releases will no longer be supported when they reach end-of-life.