Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos and add spellchecking to CI #325

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Fix various typos and add spellchecking to CI #325

merged 4 commits into from
Apr 16, 2021

Conversation

invidian
Copy link
Contributor

@invidian invidian commented Apr 15, 2021

Is this a new chart

No.

What this PR does / why we need it:

Fixes typos and adds spell checking as part of CI process.

Special notes for your reviewer:

Not sure if this is going to work. If not, I'll split into multiple PRs.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2021

CLA assistant check
All committers have signed the CLA.

Adds configuration for running codespell locally to check for possible
typos. In the future this configuration file should be used by CI as
well, but this is currently not possible until this PR gets merged:
codespell-project/codespell#1668

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
To avoid adding obvious typos.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Copy link
Contributor

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this! I'm... kind of ashamed of seeing so many stupid misspellsed words ^^U

@roobre roobre merged commit b5a81d0 into newrelic:master Apr 16, 2021
@invidian invidian deleted the invidian/typos branch April 16, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants