fix issue with missing query params

newrelic · Jun 22, 2023 · e968d39 · e968d39
1 parent 5d743bf
commit e968d39
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/common/harvest/harvest.js b/src/common/harvest/harvest.js
@@ -244,7 +244,14 @@ export class Harvest extends SharedContext {
       }
       return Object.entries(input || {})
         .reduce((accumulator, [key, value]) => {
-          if (value !== null && value !== undefined && value.length) {
+          if (
+            value !== null &&
+            value !== undefined && (
+              (typeof value === 'number') ||
+              (typeof value === 'string' && value.length > 0) ||
+              (Object.entries(value).length > 0)
+            )
+          ) {
             accumulator[key] = value
           }
 

diff --git a/src/common/harvest/harvest.test.js b/src/common/harvest/harvest.test.js
@@ -813,4 +813,20 @@ describe('cleanPayload', () => {
     expect(Object.keys(results.body)).not.toContain('foo')
     expect(Object.keys(results.qs)).not.toContain('foo')
   })
+
+  test.each([
+    { [faker.datatype.uuid()]: { [faker.datatype.uuid()]: faker.datatype.number({ min: 100, max: 1000 }) } },
+    { [faker.datatype.uuid()]: faker.datatype.number({ min: 100, max: 1000 }) },
+    { [faker.datatype.uuid()]: new Uint8Array(faker.datatype.number({ min: 100, max: 1000 })) }
+  ])('should retain %s properties in body and qs', (input) => {
+    const payload = {
+      body: input,
+      qs: input
+    }
+
+    const results = harvestInstance.cleanPayload(payload)
+
+    expect(results.body).toEqual(input)
+    expect(results.qs).toEqual(input)
+  })
 })