-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relative timestamps in session trace #1142
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
+ Coverage 88.77% 88.85% +0.07%
==========================================
Files 162 162
Lines 7289 7303 +14
Branches 1444 1446 +2
==========================================
+ Hits 6471 6489 +18
+ Misses 707 705 -2
+ Partials 111 109 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In rare cases where PerformanceNavigationTiming API is undefined, session trace timing nodes would be reported using epoch timestamp values instead of relative timestamp values. This would result in a broken session trace experience in New Relic. If the PerformanceNavigationTiming API is unavailable, the epoch timestamps will now be converted to relative timestamps accounting for user clock difference with New Relic servers.
Overview
Added code to convert epoch timestamps from
performance.timing
to relative timestamps correcting for NR server time.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-297306
Testing