fix: Disable session tracking when missing browser API #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 88.77% 88.73% -0.05%
==========================================
Files 162 162
Lines 7306 7306
Branches 1451 1450 -1
==========================================
- Hits 6486 6483 -3
- Misses 716 719 +3
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cwli24
reviewed
Aug 12, 2024
There was a problem hiding this comment.
This affects session manager; it should only prevent traces & replay as discussed.
|
Closing in favor of #1142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable session tracking when the browser is missing the PerformanceNavigationTiming api. This only happens with unsupported browsers and results in session trace data with the timing values in the wrong format.
Overview
If
PerformanceNavigationTimingis not defined, in the case of old unsupported browsers, session tracking will be disabled.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-297306
Testing