feat: Migrate RUM network call from GET to POST #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhousley
added
medium
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 24.48% 25.88% +1.40%
==========================================
Files 125 127 +2
Lines 4251 4299 +48
Branches 1087 1100 +13
==========================================
+ Hits 1041 1113 +72
+ Misses 2544 2538 -6
+ Partials 666 648 -18
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjfield
changed the title
Co-authored-by: Jordan Porter <insomniacrampage@hotmail.com>
metal-messiah
approved these changes
Jun 1, 2023
bjfield
reviewed
Jun 1, 2023
bjfield
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making its initial network call (the RUM call), the agent will now use the POST method instead of the GET method and will not depend on JSON-P to trigger follow-on events. This change facilitates setting custom attributes in the request body, reducing the likelihood of long GET URLs.
Overview
Migrating the rum api from a JSON-P GET call to a POST call.
Related Issue(s)
https://issues.newrelic.com/browse/NEWRELIC-7999
Testing
Integration tests should be ran and should pass.
DO NOT MERGE until the DEMPLA team completes the downstream requirements.