fix: Fix illegal invocation error on final harvest #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhousley
commented
Jun 22, 2023
metal-messiah
approved these changes
Jun 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 67.54% 68.12% +0.58%
==========================================
Files 132 129 -3
Lines 5907 5993 +86
Branches 1084 1141 +57
==========================================
+ Hits 3990 4083 +93
Misses 1547 1547
+ Partials 370 363 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
cwli24
reviewed
Jun 22, 2023
cwli24
reviewed
Jun 22, 2023
cwli24
approved these changes
Jun 22, 2023
bjfield
changed the title
bjfield
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue from 1.234.0 has been addressed in which an illegal invocation error could occur during a final harvest as a result of calling
addPageActionand passingwindow.locationas an argument before a navigation.Overview
Reverting a change from #521. Calling
addPageActionand passingwindow.locationas an argument before a navigation would result in calling.toStringon the globalwindow.location. Doing so during a page unload causes anIllegal Invocationerror due to the globalwindow.location.toString()losing it's context.Related Issue(s)
https://issues.newrelic.com/browse/NEWRELIC-9370
Testing
Test added to ensure this issue does not happen again.