Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report Page Actions with Generic Events Feature #1124

Merged
merged 25 commits into from
Aug 5, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jul 25, 2024

Report all customer PageAction data utilizing the new Generic Events feature.

Overview

Reroute PageActions to report through the GenericEvents feature. Behavior should remain the same. This PR is branched from #1121 , review and merge that one first

Related Issue(s)

NR-291172
NR-291174

Testing

Existing PageAction tests should continue to pass

Copy link

github-actions bot commented Jul 25, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.51 kB / 11.31 kB (gzip) 32.46 kB / 11.3 kB (gzip) -0.14% / -0.06% (gzip)
lite async-chunk 51.19 kB / 16.44 kB (gzip) 51.03 kB / 16.42 kB (gzip) -0.31% / -0.13% (gzip)
pro loader 53.69 kB / 18.04 kB (gzip) 53.49 kB / 18.03 kB (gzip) -0.37% / -0.06% (gzip)
pro async-chunk 99.59 kB / 29.65 kB (gzip) 97.63 kB / 29.25 kB (gzip) -1.97% / -1.34% (gzip)
spa loader 61.65 kB / 20.51 kB (gzip) 61.45 kB / 20.47 kB (gzip) -0.32% / -0.17% (gzip)
spa async-chunk 114.69 kB / 33.96 kB (gzip) 112.73 kB / 33.57 kB (gzip) -1.71% / -1.15% (gzip)
lite-polyfills loader 126.03 kB / 40.79 kB (gzip) 125.99 kB / 40.77 kB (gzip) -0.04% / -0.03% (gzip)
lite-polyfills async-chunk 68.02 kB / 18.91 kB (gzip) 67.86 kB / 18.89 kB (gzip) -0.23% / -0.09% (gzip)
pro-polyfills loader 149.08 kB / 46.99 kB (gzip) 148.68 kB / 46.97 kB (gzip) -0.27% / -0.05% (gzip)
pro-polyfills async-chunk 124.35 kB / 32.1 kB (gzip) 121.11 kB / 31.66 kB (gzip) -2.61% / -1.38% (gzip)
spa-polyfills loader 157.28 kB / 49.15 kB (gzip) 156.87 kB / 49.12 kB (gzip) -0.26% / -0.06% (gzip)
spa-polyfills async-chunk 142.35 kB / 36.8 kB (gzip) 139.11 kB / 36.36 kB (gzip) -2.28% / -1.2% (gzip)

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (89bc84a) to head (65aacdb).
Report is 2 commits behind head on main.

Files Patch % Lines
src/features/page_action/instrument/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   88.13%   88.74%   +0.61%     
==========================================
  Files         164      162       -2     
  Lines        7375     7305      -70     
  Branches     1463     1452      -11     
==========================================
- Hits         6500     6483      -17     
+ Misses        757      718      -39     
+ Partials      118      104      -14     
Flag Coverage Δ
unit-tests 79.10% <88.88%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 25, 2024

Static Badge

Last ran on August 01, 2024 17:49:28 CDT
Checking merge of (a065964) into main (89bc84a)

package.json Outdated Show resolved Hide resolved
src/common/config/state/init.js Outdated Show resolved Hide resolved
src/common/drain/drain.js Outdated Show resolved Hide resolved
src/features/generic_events/aggregate/index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/loaders/agent-base.js Show resolved Hide resolved
patrickhousley
patrickhousley previously approved these changes Aug 2, 2024
@metal-messiah metal-messiah merged commit 0d52acf into main Aug 5, 2024
18 checks passed
@metal-messiah metal-messiah deleted the generic-events-page-actions branch August 5, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants