feat: Aggregate log events based on rum flag #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## auto-logging #1253 +/- ##
===============================================
Coverage ? 89.11%
===============================================
Files ? 169
Lines ? 7371
Branches ? 1478
===============================================
Hits ? 6569
Misses ? 682
Partials ? 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Last ran on |
metal-messiah
approved these changes
Nov 15, 2024
Many tests rely on console.log in order to not fail
|
Mentioned in standup today (and got ack'd) that the default level was changed after the initial approval. We will re-review again when officially merging feat branch to main, so gonna go ahead and merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate logging events according to the
logflag received from rum call to BCS.Overview
Part 2 of the auto-logging feature work. This work will enable the logging feature to be controlled via BCS, which is ultimately based on user settings from UI (on/off, sampling, log level).
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-323597
Testing
Extended existing logging aggregate unit and e2e tests around handling the flag. Includes tests for each logging mode to ensure log messages of equal or higher levels are collected. For example, if the
logflag = 3 (INFO), then collectconsole.error,console.warn,console.info, andconsole.logevents.Extended existing tests to ensure no harvests when rum flag = 0 and events are drained.