-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update babel targets and tests to match support statement (NEWRELIC-5417) #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfield
changed the title
Update babel targets to match support statement.
Update babel targets to match support statement (NEWRELIC-5417)
Jan 4, 2023
|
bjfield
force-pushed
the
chore/NEWRELIC-5417_match-babel-targets-support
branch
from
January 5, 2023 16:41
ca079a2
to
4326e41
Compare
patrickhousley
previously approved these changes
Jan 5, 2023
metal-messiah
approved these changes
Jan 6, 2023
cwli24
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ
bjfield
changed the title
Update babel targets to match support statement (NEWRELIC-5417)
Update babel targets and tests to match support statement (NEWRELIC-5417)
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our working support statement is
last 10 versions of Chrome, Safari, Firefox, and Edge on mobile and desktop
. This PR:sauce-browsers.js
to generatebrowsers-supported.json
using the same browserslist source that we use to calculate version targets for babel transpilation--ensuring version-range parity.Related Issue(s)
NEWRELIC-5417
Testing
Automated tests should pass prior to merge.
Notes on reintroduced Android Chrome testing support