Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logger string interpolation (#1104) #1105

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

noahmmcgivern
Copy link
Contributor

Amends the commit message to allow for releases.

Copy link
Contributor

@Avinash-Sanpala Avinash-Sanpala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.90%. Comparing base (acdbc6d) to head (c7808d4).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/events/events_batch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files          86       86           
  Lines        5590     5590           
=======================================
  Hits         2175     2175           
  Misses       3249     3249           
  Partials      166      166           
Flag Coverage Δ
unit 38.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noahmmcgivern noahmmcgivern merged commit ce39e70 into main Mar 1, 2024
8 of 10 checks passed
@noahmmcgivern noahmmcgivern deleted the fix/amend-commit-message branch March 1, 2024 15:07
mbazhlekova pushed a commit that referenced this pull request Mar 20, 2024
Co-authored-by: mwu3535 <135672454+mwu3535@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants