fix(azure_link_account): add update capability for all fields in azure cloud link account #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagrawal-newrelic
force-pushed
the
cloud-update-account
branch
from
72cedf8
to
5b65587
Compare
vagrawal-newrelic
changed the title
…e link account fix(azure link account): remove argument override fix(azure link account): add update capability for all fields in azure cloud link account
vagrawal-newrelic
force-pushed
the
cloud-update-account
branch
from
e250062
to
1a36fd4
Compare
Comment on lines
+480
to
+483
| exclude_fields: | ||
| - "integration" | ||
| - "integrations" | ||
| - "provider" |
There was a problem hiding this comment.
why this 🤔 (am I missing something)
There was a problem hiding this comment.
in the response linkedAccounts some arguments have mandatory fields. Due to which I was getting error expected int but got nil( Please refer to the image- id field is mandatory for the integration argument )
As we don't require any field from these arguments for the update functionality so excluded it!
Please note we are saving only the below fields in the terraform state.
pranav-new-relic
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed (if relevant).
earlier newrelic_azure_link_account resource was providing only renaming of the link account feature. This PR include changes which will allow users to update all the fields for the resource.
These changes are done as a part of this help request.
jira ticket: https://new-relic.atlassian.net/browse/NR-323227
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Checklist:
Please delete options that are not relevant.
My commit message follows conventional commits
My code is formatted to Go standards
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.