Dynamically created assemblies will not be instrumented by the .NET Agent in .NET 7

[angelatan2]

Our agent support for .NET 7 instrumentation may depend on the release of the resolution of
dotnet/runtime#77068
dotnet/runtime#77533

[workato-integration]

https://issues.newrelic.com/browse/NEWRELIC-4919

[workato-integration]

Jira CommentId: 116263
Commented by angelatan:

Dependencies on .NET 7 patch release by Microsoft. (Target: Jan 2023)

[workato-integration]

Jira CommentId: 144280
Commented by angelatan:

1/30/2023

The fix was merged a couple of months ago, but it hasn't been included in any releases yet. Microsoft has only pushed out security fixes since then. We are keeping an eye on release notes as they come out.

[workato-integration]

Jira CommentId: 153202
Commented by chynes:

Somehow I missed that this was included in the 7.0.1 release in December: [https://github.com/dotnet/runtime/issues?q=milestone%3A7.0.1+is%3Aclosed+label%3Aservicing-approved+]

This is ready for verification.

[workato-integration]

Jira CommentId: 171860
Commented by mtippin:

After quite a bit of testing, I've determined that the agent will not instrument dynamically generated assemblies at all.

Tried under .NET 6 and .NET 7 (latest releases), using attribute-based instrumentation and XML instrumentation. In every case, the dynamically generated method was not instrumented. 

When using attribute-based instrumentation, the profiler acted like it was trying to reJIT the dynamic method but didn't do anything:
[Trace] 2023-03-21 21:27:34 JITCompilationStarted. 140717006813776
[Trace] 2023-03-21 21:27:34 Possibly instrumenting: (Module: RefEmit_InMemoryManifestModule, AppDomain: clrhost)[DynamicAssembly]DynamicType.MyDynamicMethod(System.Int32,System.Int32)
[Debug] 2023-03-21 21:27:34 Request reJIT: [140717006813776] (Module: RefEmit_InMemoryManifestModule, AppDomain: clrhost)[DynamicAssembly]DynamicType.MyDynamicMethod(System.Int32,System.Int32)
[Trace] 2023-03-21 21:27:34 JITCompilationStartedFinished. 140717006813776
When using XML-based instrumentation, the profiler logged an exception:
[Trace] 2023-03-22 16:59:26 JITCompilationStarted. 140717310921824
[Error] 2023-03-22 16:59:26 Win32 function call failed. Function: _profilerInfo->GetILFunctionBody HRESULT: 0x80131351
[Error] 2023-03-22 16:59:26 An exception was thrown while getting details about a function.
[Trace] 2023-03-22 16:59:26 JITCompilationStartedFinished. 140717310921824
I did verify, however, that calling an instrumented method from a dynamically generated method does instrument the instrumented method as expected. 

There's a newer ICorProfiler interface (ICorProfiler8) that includes methods specifically about [JIT compilation of dynamic methods|https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/profiling/icorprofilercallback8-dynamicmethodjitcompilationstarted-method]. Perhaps we should consider implementing support for those methods - though I have no idea if that will resolve this issue or not.

[workato-integration]

Jira CommentId: 171860
Commented by mtippin:

After quite a bit of testing, I've determined that the agent will not instrument dynamically generated assemblies at all.

Tried under .NET 6 and .NET 7 (latest releases), using attribute-based instrumentation and XML instrumentation. In every case, the dynamically generated method was not instrumented. 

When using attribute-based instrumentation, the profiler acted like it was trying to reJIT the dynamic method but didn't do anything:

 
{code:java}
[Trace] 2023-03-21 21:27:34 JITCompilationStarted. 140717006813776
[Trace] 2023-03-21 21:27:34 Possibly instrumenting: (Module: RefEmit_InMemoryManifestModule, AppDomain: clrhost)[DynamicAssembly]DynamicType.MyDynamicMethod(System.Int32,System.Int32)
[Debug] 2023-03-21 21:27:34 Request reJIT: [140717006813776] (Module: RefEmit_InMemoryManifestModule, AppDomain: clrhost)[DynamicAssembly]DynamicType.MyDynamicMethod(System.Int32,System.Int32)
[Trace] 2023-03-21 21:27:34 JITCompilationStartedFinished. 140717006813776{code}
When using XML-based instrumentation, the profiler logged an exception:
{code:java}
[Trace] 2023-03-22 16:59:26 JITCompilationStarted. 140717310921824
[Error] 2023-03-22 16:59:26 Win32 function call failed. Function: _profilerInfo->GetILFunctionBody HRESULT: 0x80131351
[Error] 2023-03-22 16:59:26 An exception was thrown while getting details about a function.
[Trace] 2023-03-22 16:59:26 JITCompilationStartedFinished. 140717310921824{code}
I did verify, however, that calling an instrumented method from a dynamically generated method does instrument the instrumented method as expected. 

There's a newer ICorProfiler interface (ICorProfiler8) that includes methods specifically about [JIT compilation of dynamic methods|https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/profiling/icorprofilercallback8-dynamicmethodjitcompilationstarted-method]. Perhaps we should consider implementing support for those methods - though I have no idea if that will resolve this issue or not.

[workato-integration]

This issue won't be actioned.