-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit ICorProfiler ModuleLoadFinished for dynamic modules #77068
Emit ICorProfiler ModuleLoadFinished for dynamic modules #77068
Conversation
Tagging subscribers to this area: @tommcdon |
@davmason Hi! It turned out to be a critical issue for us and for our customers. Will this fix be included in 7.0 rc3, is there anything we can do for that? |
The servicing PR for 7.0 is here: #77533 |
It seems like this commit might have caused one of the regressions in this issue: dotnet/perf-autofiling-issues#9181 Specifically, the System.Memory.Span.BinarySearch regression. |
Hi @dakersnar, Do you have any exiting investigation you can point me to? Off the top of my head I would be very surprised if this fix caused a regression in binary search, it is only called on module load and only if a profiler is attached. But stranger things have happened |
#63157 introduced a regression where we do not call ModuleLoadFinished for dynamic modules
Fixes #76016