Clean up POC #2839
Merged
Clean up POC #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chynesNR
reviewed
Oct 18, 2024
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Parsing/StringsHelper.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/dynamodb-instrumentation #2839 +/- ##
====================================================================
- Coverage 81.31% 81.24% -0.08%
====================================================================
Files 460 460
Lines 29224 29259 +35
Branches 3231 3235 +4
====================================================================
+ Hits 23764 23771 +7
- Misses 4668 4694 +26
- Partials 792 794 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nr-ahemsath
merged commit e12dba2
into
feature/dynamodb-instrumentation
90 of 93 checks passed
nrcventura
reviewed
Oct 21, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AwsSdk/DynamoDbRequestHandler.cs
Show resolved
Hide resolved
nrcventura
reviewed
Oct 21, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/Memcached/MemcachedHelpers.cs
Show resolved
Hide resolved
nr-ahemsath
added a commit
that referenced
this pull request
Oct 29, 2024
* Bring initial POC to feature branch (#2836) * First pass at DynamoDB support * db.system attribute was not being set correctly --------- Co-authored-by: chynesNR <chynes@newrelic.com> * Clean up POC (#2839) * Remove datastore vendor name from ConnectionInfo in MemcachedHelpers * Get operation name from request type by converting PascalCaseRequest to snake_case * Make operation name cache thread safe (#2841) * Make operation name cache thread safe * Cleaner implementation based on PR feedback * Update src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AwsSdk/DynamoDbRequestHandler.cs Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com> --------- Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com> * DynamoDB integration tests (#2854) * Rename things in preparation to add another AWS SDK test type * Add project dependencies * More renaming * Initial plumbing created * More cleanup * Forklift exerciser methods from standalone test app * Working tests * Cleanup * Fix port assignment issue seen in CI * Only wait up to two minutes for table to become active * List ports in use in container tests host For temporary troubleshooting * Update tests/Agent/IntegrationTests/ContainerApplications/AwsSdkTestApp/AwsSdkExercisers/AwsSdkDynamoDBExerciser.cs Co-authored-by: Marty T <120425148+tippmar-nr@users.noreply.github.com> * Fix port conflict issue plus PR feedback --------- Co-authored-by: Marty T <120425148+tippmar-nr@users.noreply.github.com> * Add unit tests for ToSnakeCase() (#2859) Unit tests for ToSnakeCase() --------- Co-authored-by: chynesNR <chynes@newrelic.com> Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com> Co-authored-by: Marty T <120425148+tippmar-nr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change is that instead of using a switch statement to convert request type names like "PutItemRequest" and "CreateTableRequest" to operation names like
put_itemandcreate_table, instead use a formula of "remove the trailingRequestand then convert PascalCase to snake_case".There was also a minor merge conflict in the new Memcache instrumentation which was created after the original POC was done.