test: Make metric validation more consistent #2840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common source of intermittent integration test failures are cases where we're looking for multiple occurrences of a metric, since there's always a small chance that they fall over more than one harvest cycle. I used a regex to find all of the cases where we're looking for multiple instances, and changed them to check all harvests.
This touched a lot of files but only contains two changes:
callCount
withCallCountAllHarvests
where appropriateTryFindMetrics()
(which broke on regex scope assertions that encountered a null scope)