fix: Remove usage of non-thread safe HashSet in AwsSdk pipeline wrappers. (#2855) #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2857 +/- ##
=======================================
Coverage 81.39% 81.40%
=======================================
Files 464 464
Lines 29504 29504
Branches 3262 3262
=======================================
+ Hits 24016 24018 +2
+ Misses 4694 4693 -1
+ Partials 794 793 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
chynesNR
approved these changes
Oct 28, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ConcurrentHashSet<T>instead ofHashSet<T>in AWSSdk wrapper to resolve a threading issue.Resolves #2855. Replaces #2856.
Co-authored-by: Gideon @gjunge