Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validate_custom_event validators into validators directory #1089

Merged
merged 13 commits into from
Apr 16, 2024
Merged

Move validate_custom_event validators into validators directory #1089

merged 13 commits into from
Apr 16, 2024

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Mar 12, 2024

Overview

This PR moves validate_custom_event_in_application_stats_engine and validate_custom_event_count into its own separate file within the testing_support/validators directory

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 24 0 0 2.64s
✅ PYTHON flake8 24 0 1.56s
✅ PYTHON isort 24 0 0 0.27s
✅ PYTHON pylint 24 0 10.86s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei marked this pull request as ready for review March 25, 2024 16:30
@lrafeei lrafeei requested a review from a team March 25, 2024 16:30
@mergify mergify bot removed the tests-failing label Mar 27, 2024
@mergify mergify bot removed the tests-failing label Apr 16, 2024
TimPansino
TimPansino approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@TimPansino TimPansino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimPansino TimPansino merged commit 780f4a2 into main Apr 16, 2024
47 of 49 checks passed
@TimPansino TimPansino deleted the validate-custom-event-move branch April 16, 2024 19:12
@mergify mergify bot removed the tests-failing label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPansino TimPansino TimPansino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrafeei @TimPansino