Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR Control Health Checks #1250

Draft
wants to merge 8 commits into
base: super-agent
Choose a base branch
from
Draft

Conversation

umaannamalai
Copy link
Contributor

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Copy link

github-actions bot commented Nov 8, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 5 0 7.11s
✅ PYTHON black 7 4 0 4.81s
❌ PYTHON flake8 7 1 1.36s
✅ PYTHON isort 7 7 0 0.31s
✅ PYTHON pylint 7 0 10.71s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing label Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 89.61039% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (0e0ddb8) to head (a19b7db).
Report is 3 commits behind head on super-agent.

Files with missing lines Patch % Lines
newrelic/core/super_agent_health.py 90.17% 7 Missing and 4 partials ⚠️
newrelic/core/agent_protocol.py 86.66% 1 Missing and 1 partial ⚠️
newrelic/core/application.py 77.77% 2 Missing ⚠️
newrelic/config.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           super-agent    #1250    +/-   ##
=============================================
  Coverage        81.35%   81.36%            
=============================================
  Files              200      201     +1     
  Lines            21899    22059   +160     
  Branches          3470     3499    +29     
=============================================
+ Hits             17816    17948   +132     
- Misses            2941     2958    +17     
- Partials          1142     1153    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants